• zeripath's avatar
    Prevent panic in doctor command when running default checks (#21791) (#21808) · 9dc53ba6
    zeripath authored
    
    
    Backport #21791
    
    There was a bug introduced in #21352 due to a change of behaviour caused
    by #19280. This causes a panic on running the default doctor checks
    because the panic introduced by #19280 assumes that the only way
    opts.StdOut and opts.Stderr can be set in RunOpts is deliberately.
    Unfortunately, when running a git.Command the provided RunOpts can be
    set, therefore if you share a common set of RunOpts these two values can
    be set by the previous commands.
    
    This PR stops using common RunOpts for the commands in that doctor check
    but secondly stops RunCommand variants from changing the provided
    RunOpts.
    Signed-off-by: default avatarAndrew Thornton <art27@cantab.net>
    9dc53ba6
command.go 10.3 KB