• 6543's avatar
    Add API for Issue set Subscription (#8729) · 5a187f4b
    6543 authored
    
    * add issue subscriber API
    
    * subscribers return []user.APIFormat
    
    * add comments
    
    * more meaningfull description
    
    * without "reqToken()" api works ...
     * should be still secure beause ctx.user has to be there or nothing will hapen
    
    * FIX: getIssueWatchers() get only aktive suscriber
    
    * add return avter error on right position
    
    * Revert "FIX: getIssueWatchers() get only aktive suscriber"
    
    This reverts commit 5eca9291858a821981992b0aaa38cef610d84bca.
    
    * Update routers/api/v1/repo/issue.go
    Co-Authored-By: default avatarguillep2k <18600385+guillep2k@users.noreply.github.com>
    
    * test go linter again
    
    * update swagger
    
    * GetIssueWatchers -> GetIssueSubscribers
    
    part one
    Co-Authored-By: default avatarguillep2k <18600385+guillep2k@users.noreply.github.com>
    
    * GetIssueWatchers -> GetIssueSubscribers
    part two
    
    * Revert "test go linter again"
    
    This reverts commit bab12356227e44334de113b76f12099de0b8aaa6.
    
    * change description for unsubscribe too
    
    * golangci-lint timeout avter 5min
    
    * move issueSubscription to seperate file
    
    * dont create black entitys
    
    * use IsWatching until refactoring
    
    * Update License Info
    
    * better swagger description
    
    * Update .golangci.yml
    
    because functions moved from issue.go to issue_subscription.go
    
    * add IssueWatchList type
    
    * batch tasks
    
    * use e Engien
    
    * add error handling
    
    * error should be the last type when returning multiple items
    
    * short version
    
    * reurn empy UserList instead of nil
    5a187f4b
.golangci.yml 2.09 KB
linters:
  enable:
    - gosimple
    - deadcode
    - typecheck
    - govet
    - errcheck
    - staticcheck
    - unused
    - structcheck
    - varcheck
    - golint
    - dupl
    #- gocyclo # The cyclomatic complexety of a lot of functions is too high, we should refactor those another time.
    - gofmt
    - misspell
    - gocritic
  enable-all: false
  disable-all: true
  fast: false

run:
  timeout: 3m

linters-settings:
  gocritic:
    disabled-checks:
      - ifElseChain
      - singleCaseSwitch # Every time this occured in the code, there  was no other way.

issues:
  exclude-rules:
    # Exclude some linters from running on tests files.
    - path: _test\.go
      linters:
        - gocyclo
        - errcheck
        - dupl
        - gosec
        - unparam
        - staticcheck
    - path: models/migrations/v
      linters:
        - gocyclo
        - errcheck
        - dupl
        - gosec
    - linters:
        - dupl
      text: "webhook"
    - linters:
        - gocritic
      text: "`ID' should not be capitalized"
    - path: modules/templates/helper.go
      linters:
        - gocritic
    - linters:
        - unused
        - deadcode
      text: "swagger"
    - path: contrib/pr/checkout.go
      linters:
        - errcheck
    - path: models/issue.go
      linters:
        - errcheck
    - path: models/migrations/
      linters:
        - errcheck
    - path: modules/log/
      linters:
        - errcheck
    - path: routers/routes/routes.go
      linters:
        - dupl
    - path: routers/api/v1/repo/issue_subscription.go
      linters:
        - dupl
    - path: routers/repo/view.go
      linters:
        - dupl
    - path: models/migrations/
      linters:
        - unused
    - linters:
        - staticcheck
      text: "argument x is overwritten before first use"
    - path: modules/httplib/httplib.go
      linters:
        - staticcheck
    # Enabling this would require refactoring the methods and how they are called.
    - path: models/issue_comment_list.go
      linters:
        - dupl
    - linters:
        - misspell
      text: '`Unknwon` is a misspelling of `Unknown`'