- 11 Jul, 2022 1 commit
-
-
wxiaoguang authored
Backport #20299. Follow #20298. Only the `GlobalInitInstalled` function should prepare the SSH files for external server or starts the builtin server. * `trustedUserCaKeys` is removed, use `SSH.TrustedUserCAKeys` directly * introduce `ssh.Init`, move the SSH init code from `routers/init.go` to it * `ssh.Init` will start builtin SSH server or prepare external SSH server files
-
- 10 Jul, 2022 2 commits
-
-
KN4CK3R authored
Addition to: Show scrollbar when necessary #20142 Fixes the "empty" scrollbars with Firefox.
-
wxiaoguang authored
Backport #20289 The code is as old as back to 2016, creating the directory automatically is not correct IMO. In other places for ssh key writing (RewriteAllPrincipalKeys / appendAuthorizedKeysToFile, etc), the directory will still be created when updating the keys. This PR will resolve the confusing and annoying problem: the dummy and empty ".ssh" directory in new git home
-
- 09 Jul, 2022 2 commits
-
-
Gusted authored
Backport #20300 - Update goldmark to v1.4.13 to fix a issue with quotes after a empty list item(See https://github.com/yuin/goldmark/issues/313) and downstream issue https://codeberg.org/Codeberg/Community/issues/645
-
Gusted authored
Backport #20275 Currently when a Team has read access to a organization's non-private repository, their access(in the `access` table) won't be stored in the database. This cause issues for code that rely on read access being stored, like retrieving all users who have read permission to that repository(even though this is confusing as this doesn't include all registered users). So from now-on if we see that the repository is owned by a organization don't increase the `minMode` to write permission. Resolves #20083
-
- 08 Jul, 2022 1 commit
-
-
wxiaoguang authored
Before, in #19732, the old home directory is not correct. This PR introduces a new config option for git home: git.HOME_PATH, which is default to %(APP_DATA_PATH)/home And pass env GNUPGHOME to git command, force Gitea to use a stable GNUPGHOME directory
-
- 07 Jul, 2022 2 commits
-
-
zeripath authored
Backport #20108 Backport #20236 Backport #20251 Make notification bell more prominent on mobile Co-authored-by:
Andrew Thornton <art27@cantab.net> Co-authored-by:
Tyrone Yeh <siryeh@gmail.com> Signed-off-by:
Andrew Thornton <art27@cantab.net>
-
Gusted authored
- Backport (#20277 - This code is only valid when `refNumeric` exist(otherwise we didn't find such numeric PR and can skip that check) and give a free-pas to the "BEFORE" check when `ref` is nil. - Resolves #20109
-
- 06 Jul, 2022 2 commits
-
-
zeripath authored
Backport #20220 Users who are following or being followed by a user should only be displayed if the viewing user can see them. Signed-off-by:
Andrew Thornton <art27@cantab.net>
-
zeripath authored
Backport #20200 The uid provided to the group filter must be properly escaped using the provided ldap.EscapeFilter function. Fix #20181 Signed-off-by:
Andrew Thornton <art27@cantab.net>
-
- 05 Jul, 2022 4 commits
-
-
zeripath authored
Backport #20171 The setting `DEFAULT_SHOW_FULL_NAME` promises to use the user's full name everywhere it can be used. Unfortunately the function `*user_model.User.ShortName()` currently uses the `.Name` instead - but this should also use the `.FullName()`. Therefore we should make `*user_model.User.ShortName()` base its pre-shortened name on the `.FullName()` function. Co-authored-by:
Baekjun Kim <36013575+kimbj95@users.noreply.github.com>
-
zeripath authored
Backport #20243 Adjust the max-widths for the repository file table to allow for nicer resizing of the names and commit messages. Fix #20040 Signed-off-by:
Andrew Thornton <art27@cantab.net> ## Screenshots ## MediaXL  ## MediaLg  ## MediaMd  ## MediaSm  Co-authored-by:
Lunny Xiao <xiaolunwen@gmail.com>
-
wxiaoguang authored
Backport #20244 * https://github.com/go-gitea/gitea/issues/20240 At the moment, Firefox (iOS) (10x) has an engine bug. See https://github.com/go-gitea/gitea/issues/20240 If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0. This PR ignores such nonsense error event. Fix #20240
-
Gusted authored
- Backport #20234 - Initialize the popup for the tooltip inside the new code comment. - This works and is good enough to have this issue fixed for 1.17 Fix #20068
-
- 04 Jul, 2022 1 commit
-
-
zeripath authored
-
- 02 Jul, 2022 1 commit
-
-
zeripath authored
Backport #20158 Unforunately the previous PR #20035 created indices that were not helpful for SQLite. This PR adjusts these after testing using the try.gitea.io db. Fix #20129 Signed-off-by:
Andrew Thornton <art27@cantab.net>
-
- 01 Jul, 2022 4 commits
-
-
wxiaoguang authored
* Fix `dump-repo` git init * Fix wrong error type for NullDownloader
-
wxiaoguang authored
-
Lunny Xiao authored
Check if project has the same repository id with issue when assign project to issue (#20133) (#20188) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by:
Gusted <williamzijl7@hotmail.com> Co-authored-by:
KN4CK3R <admin@oldschoolhack.me> Co-authored-by:
6543 <6543@obermui.de>
-
silverwind authored
Synced the list to what is allowed on GitHub currently.
-
- 27 Jun, 2022 1 commit
-
-
Gusted authored
- Backport #20142 - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary. - Resolves #20139
-
- 25 Jun, 2022 1 commit
-
-
Gusted authored
Backport #20127 Store the file uuid(which is returned by Gitea in the upload file response) onto the file object, so it can be used for the remove feature to specify this file. Fix #20115
-
- 24 Jun, 2022 2 commits
-
-
Lunny Xiao authored
-
SteveTheEngineer authored
The code introduced by #18185 gets the error from response after it was processed by goth. That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth. It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed. This fixes it by handling the error before the request is passed to goth.
-
- 23 Jun, 2022 1 commit
-
-
Jimmy Praet authored
Fixes #20080
-
- 22 Jun, 2022 1 commit
-
-
Lunny Xiao authored
-
- 21 Jun, 2022 1 commit
-
-
6543 authored
Backport #20070 Just get all tags when creating the compare dropdown. Fix #19936
-
- 20 Jun, 2022 3 commits
-
-
6543 authored
Co-authored-by:
Gusted <williamzijl7@hotmail.com> Co-authored-by:
delvh <dev.lh@web.de> Co-authored-by:
zeripath <art27@cantab.net> Co-authored-by:
Lauris BH <lauris@nix.lv> Co-authored-by:
Lunny Xiao <xiaolunwen@gmail.com>
-
Gusted authored
* Disable federation by default (#20045) - Backport #20045 - A Gitea instance should choose whetever they want to federate(as once it has more features also brings extra costs/moderation/unexpected behavior) with other AP/ForgeFed software. * Fix tests
-
zeripath authored
There appears to be a strange bug whereby the comment_id index can sometimes be missed or missing from the action table despite the sync2 that should create it in the earlier part of this migration. However, looking through the code for Sync2 there is no need for this pre-code to exist and Sync2 should drop/create the indices as necessary. I think therefore we should simplify the migration to simply be Sync2. Signed-off-by:
Andrew Thornton <art27@cantab.net> Co-authored-by:
6543 <6543@obermui.de>
-
- 19 Jun, 2022 6 commits
-
-
Wim authored
Mysql TEXT has a limit of 64KB, change this to LONGTEXT in mysql only so we can have bigger hook payloads. Postgresql has unlimited TEXT - https://www.postgresql.org/docs/current/datatype-character.html Sqlite has unlimited TEXT - https://www.sqlitetutorial.net/sqlite-data-types/#:~:text=The%20maximum%20length%20of%20TEXT,SQLite%20supports%20various%20character%20encodings . Backport of #20038 Co-authored-by:
zeripath <art27@cantab.net>
-
zeripath authored
Backport #20019 - Resolves #20018
-
Wim authored
Fixes #19090 If the user-agent starts with git and user must change password but hasn't return a 401 with the message. It must be a 401, git doesn't seem to show the contents of the error message when we return a 403 Co-authored-by:
6543 <6543@obermui.de>
-
a1012112796 authored
Backport #20032 In DeleteIssue the PR git head reference should be `/refs/pull/xxx/head` not `/refs/pull/xxx` Fix #19655 Signed-off-by:
a1012112796 <1012112796@qq.com>
-
wxiaoguang authored
Backport #20029
-
6543 authored
Co-authored-by:
wxiaoguang <wxiaoguang@gmail.com>
-
- 18 Jun, 2022 4 commits
-
-
Wim authored
Fixes #19979
-
zeripath authored
-
zeripath authored
-
zeripath authored
fgprof is a sampling Go profiler that allows you to analyze On-CPU as well as Off-CPU (e.g. I/O) time together. Go's builtin sampling CPU profiler can only show On-CPU time, but it's better than fgprof at that. Go also includes tracing profilers that can analyze I/O, but they can't be combined with the CPU profiler. fgprof is designed for analyzing applications with mixed I/O and CPU workloads. This kind of profiling is also known as wall-clock profiling. Whilst fgprof can cause significant STW latencies in applications with a lot of goroutines (> 1-10k), these latencies only occur if the profile is requested - it doesn't cause a delay by simply being available. The fgprof profile is mounted on `http://localhost:6060/debug/fgprof?seconds=3` Signed-off-by:
Andrew Thornton <art27@cantab.net>
-