1. 24 Jun, 2022 1 commit
    • SteveTheEngineer's avatar
      Catch the error before the response is processed by goth. (#20000) (#20102) · 764e75d9
      SteveTheEngineer authored
      The code introduced by #18185 gets the error from response after it was processed by goth.
      
      That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
      It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
      This fixes it by handling the error before the request is passed to goth.
      Unverified
      764e75d9
  2. 23 Jun, 2022 1 commit
  3. 22 Jun, 2022 1 commit
  4. 21 Jun, 2022 1 commit
  5. 20 Jun, 2022 3 commits
  6. 19 Jun, 2022 6 commits
  7. 18 Jun, 2022 10 commits
  8. 17 Jun, 2022 9 commits
  9. 16 Jun, 2022 8 commits