• Kirill A. Shutemov's avatar
    mm, dax: VMA with vm_ops->pfn_mkwrite wants to be write-notified · 8a04446a
    Kirill A. Shutemov authored
    For VM_PFNMAP and VM_MIXEDMAP we use vm_ops->pfn_mkwrite instead of
    vm_ops->page_mkwrite to notify abort write access.  This means we want
    vma->vm_page_prot to be write-protected if the VMA provides this vm_ops.
    
    A theoretical scenario that will cause these missed events is:
    
      On writable mapping with vm_ops->pfn_mkwrite, but without
      vm_ops->page_mkwrite: read fault followed by write access to the pfn.
      Writable pte will be set up on read fault and write fault will not be
      generated.
    
    I found it examining Dave's complaint on generic/080:
    
    	http://lkml.kernel.org/g/20150831233803.GO3902@dastard
    
    
    
    Although I don't think it's the reason.
    
    It shouldn't be a problem for ext2/ext4 as they provide both pfn_mkwrite
    and page_mkwrite.
    
    [akpm@linux-foundation.org: add local vm_ops to avoid 80-cols mess]
    Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Yigal Korman <yigal@plexistor.com>
    Acked-by: Boaz Harrosh <boaz@plexistor.c...
    8a04446a
mmap.c 90.1 KB