1. 02 Aug, 2018 1 commit
  2. 22 May, 2018 1 commit
  3. 25 Jan, 2018 1 commit
  4. 04 Nov, 2017 3 commits
  5. 10 Aug, 2017 1 commit
  6. 28 Mar, 2017 2 commits
  7. 16 Mar, 2017 1 commit
  8. 31 Jan, 2017 1 commit
  9. 16 Jan, 2017 1 commit
  10. 04 Jan, 2017 1 commit
    • Johan Hovold's avatar
      USB: serial: pl2303: fix NULL-deref at open · 76ab439e
      Johan Hovold authored
      Fix NULL-pointer dereference in open() should a type-0 or type-1 device
      lack the expected endpoints:
      
      Unable to handle kernel NULL pointer dereference at virtual address 00000030
      ...
      PC is at pl2303_open+0x38/0xec [pl2303]
      
      Note that a missing interrupt-in endpoint would have caused open() to
      fail.
      
      Fixes: 1da177e4
      
       ("Linux-2.6.12-rc2")
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      76ab439e
  11. 30 Jul, 2015 1 commit
    • Michał Pecio's avatar
      USB: pl2303: fix baud-rate divisor calculations · 49bda212
      Michał Pecio authored
      
      This commit fixes the following issues:
      
      1. The 9th bit of buf was believed to be the LSB of divisor's
      exponent, but the hardware interprets it as MSB (9th bit) of the
      mantissa. The exponent is actually one bit shorter and applies
      to base 4, not 2 as previously believed.
      
      2. Loop iterations doubled the exponent instead of incrementing.
      
      3. The exponent wasn't checked for overflow.
      
      4. The function returned requested rate instead of actual rate.
      
      Due to issue #2, the old code deviated from the wrong formula
      described in #1 and actually yielded correct rates when divisor
      was lower than 4096 by using exponents of 0, 2 or 4 base-2,
      interpreted as 0, 1, 2 base-4 with the 9th mantissa bit clear.
      However, at 93.75 kbaud or less the rate turned out too slow
      due to #2 or too fast due to #2 and #3.
      
      I tested this patch by sending and validating 0x00,0x01,..,0xff
      to an FTDI dongle at 234, 987, 2401, 9601, 31415, 115199, 250k,
      500k, 750k, 1M, 1.5M, 3M+1 baud. All rates passed.
      
      I also used pv to check speed at some rates unsupported by FTDI:
      45 (the lowest possible), 2M, 4M, 5M and 6M-1. Looked sane.
      Signed-off-by: default avatarMichal Pecio <michal.pecio@gmail.com>
      Fixes: 399aa9a7
      
       ("USB: pl2303: use divisors for unsupported baud
      rates")
      Cc: stable <stable@vger.kernel.org> # v3.18
      [johan: update summary ]
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      49bda212
  12. 29 Apr, 2015 1 commit
  13. 26 Feb, 2015 1 commit
  14. 01 Sep, 2014 1 commit
  15. 18 Aug, 2014 1 commit
  16. 16 Apr, 2014 1 commit
  17. 08 Jan, 2014 1 commit
  18. 03 Jan, 2014 20 commits