1. 22 Apr, 2022 1 commit
  2. 20 Apr, 2022 1 commit
  3. 18 Apr, 2022 1 commit
  4. 09 Mar, 2022 1 commit
    • Eric W. Biederman's avatar
      coredump: Don't compile flat_core_dump when coredumps are disabled · f833116a
      Eric W. Biederman authored
      Recently the kernel test robot reported:
      > In file included from include/linux/kernel.h:29,
      >                     from fs/binfmt_flat.c:21:
      >    fs/binfmt_flat.c: In function 'flat_core_dump':
      > >> fs/binfmt_flat.c:121:50: error: invalid use of undefined type 'struct coredump_params'
      >      121 |                 current->comm, current->pid, cprm->siginfo->si_signo);
      >          |                                                  ^~
      >    include/linux/printk.h:418:33: note: in definition of macro 'printk_index_wrap'
      >      418 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
      >          |                                 ^~~~~~~~~~~
      >    include/linux/printk.h:499:9: note: in expansion of macro 'printk'
      >      499 |         printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
      >          |         ^~~~~~
      >    fs/binfmt_flat.c:120:9: note: in expansion of macro 'pr_warn'
      >      120 |         pr_warn("Process %s:%d received signr %d and should have core dumped\n",
      >          |         ^~~~~~~
      >    At top level:
      >    fs/binfmt_flat.c:118:12: warning: 'flat_core_dump' defined but not used [-Wunused-function]
      >      118 | static int flat_core_dump(struct coredump_params *cprm)
      >          |            ^~~~~~~~~~~~~~
      
      The little dinky do nothing function flat_core_dump has always been
      compiled unconditionally.  With my change to move coredump_params into
      coredump.h coredump_params reasonably becomes unavailable when
      coredump support is not compiled in.  Fix this old issue by simply not
      compiling flat_core_dump when coredump support is not supported.
      
      Fixes: a99a3e2e
      
       ("coredump: Move definition of struct coredump_params into coredump.h")
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
      f833116a
  5. 08 Mar, 2022 1 commit
  6. 02 Mar, 2022 1 commit
  7. 29 Jun, 2021 1 commit
  8. 18 Apr, 2021 1 commit
    • Damien Le Moal's avatar
      binfmt_flat: allow not offsetting data start · 04d82a6d
      Damien Le Moal authored
      Commit 2217b982
      
       ("binfmt_flat: revert "binfmt_flat: don't offset
      the data start"") restored offsetting the start of the data section by
      a number of words defined by MAX_SHARED_LIBS. As a result, since
      MAX_SHARED_LIBS is never 0, a gap between the text and data sections
      always exists. For architectures which cannot support a such gap
      between the text and data sections (e.g. riscv nommu), flat binary
      programs cannot be executed.
      
      To allow an architecture to request no data start offset to allow for
      contiguous text and data sections for binaries flagged with
      FLAT_FLAG_RAM, introduce the new config option
      CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET. Using this new option, the
      macro DATA_START_OFFSET_WORDS is conditionally defined in binfmt_flat.c
      to MAX_SHARED_LIBS for architectures tolerating or needing the data
      start offset (CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET disabled case)
      and to 0 when CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET is enabled.
      DATA_START_OFFSET_WORDS is used in load_flat_file() to calculate the
      data section length and start position.
      Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
      Signed-off-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
      04d82a6d
  9. 23 Aug, 2020 1 commit
    • Max Filippov's avatar
      binfmt_flat: revert "binfmt_flat: don't offset the data start" · 2217b982
      Max Filippov authored
      binfmt_flat loader uses the gap between text and data to store data
      segment pointers for the libraries. Even in the absence of shared
      libraries it stores at least one pointer to the executable's own data
      segment. Text and data can go back to back in the flat binary image and
      without offsetting data segment last few instructions in the text
      segment may get corrupted by the data segment pointer.
      
      Fix it by reverting commit a2357223 ("binfmt_flat: don't offset the
      data start").
      
      Cc: stable@vger.kernel.org
      Fixes: a2357223
      
       ("binfmt_flat: don't offset the data start")
      Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
      Signed-off-by: default avatarGreg Ungerer <gerg@linux-m68k.org>
      2217b982
  10. 08 Jun, 2020 1 commit
  11. 03 Jun, 2020 1 commit
  12. 07 May, 2020 3 commits
  13. 17 Jul, 2019 1 commit
  14. 29 Jun, 2019 1 commit
    • Jann Horn's avatar
      fs/binfmt_flat.c: make load_flat_shared_library() work · 867bfa4a
      Jann Horn authored
      load_flat_shared_library() is broken: It only calls load_flat_file() if
      prepare_binprm() returns zero, but prepare_binprm() returns the number of
      bytes read - so this only happens if the file is empty.
      
      Instead, call into load_flat_file() if the number of bytes read is
      non-negative. (Even if the number of bytes is zero - in that case,
      load_flat_file() will see nullbytes and return a nice -ENOEXEC.)
      
      In addition, remove the code related to bprm creds and stop using
      prepare_binprm() - this code is loading a library, not a main executable,
      and it only actually uses the members "buf", "file" and "filename" of the
      linux_binprm struct. Instead, call kernel_read() directly.
      
      Link: http://lkml.kernel.org/r/20190524201817.16509-1-jannh@google.com
      Fixes: 287980e4
      
       ("remove lots of IS_ERR_VALUE abuses")
      Signed-off-by: default avatarJann Horn <jannh@google.com>
      Cc: Alexander Viro <viro@zeniv.linux.org.uk>
      Cc: Kees Cook <keescook@chromium.org>
      Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Russell King <linux@armlinux.org.uk>
      Cc: Greg Ungerer <gerg@linux-m68k.org>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      867bfa4a
  15. 23 Jun, 2019 11 commits
  16. 11 Apr, 2018 1 commit
  17. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard...
      b2441318
  18. 09 Sep, 2017 1 commit
  19. 04 Sep, 2017 1 commit
  20. 01 Aug, 2017 1 commit
  21. 16 Jul, 2017 1 commit
  22. 03 Jul, 2017 1 commit
  23. 02 Mar, 2017 1 commit
  24. 28 Jul, 2016 5 commits