1. 20 Apr, 2021 1 commit
  2. 06 Mar, 2020 1 commit
    • Masami Hiramatsu's avatar
      tools: Let O= makes handle a relative path with -C option · be40920f
      Masami Hiramatsu authored
      When I tried to compile tools/perf from the top directory with the -C
      option, the O= option didn't work correctly if I passed a relative path:
      
        $ make O=BUILD -C tools/perf/
        make: Entering directory '/home/mhiramat/ksrc/linux/tools/perf'
          BUILD:   Doing 'make -j8' parallel build
        ../scripts/Makefile.include:4: *** O=/home/mhiramat/ksrc/linux/tools/perf/BUILD does not exist.  Stop.
        make: *** [Makefile:70: all] Error 2
        make: Leaving directory '/home/mhiramat/ksrc/linux/tools/perf'
      
      The O= directory existence check failed because the check script ran in
      the build target directory instead of the directory where I ran the make
      command.
      
      To fix that, once change directory to $(PWD) and check O= directory,
      since the PWD is set to where the make command runs.
      
      Fixes: c883122a
      
       ("perf tools: Let O= makes handle relative paths")
      Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Borislav Petkov <bp@alien8.de>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Masahiro Yamada <masahiroy@kernel.org>
      Cc: Michal Marek <michal.lkml@markovi.net>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sasha Levin <sashal@kernel.org>
      Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
      Cc: stable@vger.kernel.org
      Link: http://lore.kernel.org/lkml/158351957799.3363.15269768530697526765.stgit@devnote2
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      be40920f
  3. 20 Aug, 2018 1 commit
    • Rasmus Villemoes's avatar
      perf tools: Disable parallelism for 'make clean' · da15fc2f
      Rasmus Villemoes authored
      
      The Yocto build system does a 'make clean' when rebuilding due to
      changed dependencies, and that consistently fails for me (causing the
      whole BSP build to fail) with errors such as
      
      | find: '[...]/perf/1.0-r9/perf-1.0/plugin_mac80211.so': No such file or directory
      | find: '[...]/perf/1.0-r9/perf-1.0/plugin_mac80211.so': No such file or directory
      | find: find: '[...]/perf/1.0-r9/perf-1.0/libtraceevent.a''[...]/perf/1.0-r9/perf-1.0/libtraceevent.a': No such file or directory: No such file or directory
      |
      [...]
      | find: cannot delete '/mnt/xfs/devel/pil/yocto/tmp-glibc/work/wandboard-oe-linux-gnueabi/perf/1.0-r9/perf-1.0/util/.pstack.o.cmd': No such file or directory
      
      Apparently (despite the comment), 'make clean' ends up launching
      multiple sub-makes that all want to remove the same things - perhaps
      this only happens in combination with a O=... parameter. In any case, we
      don't lose much by explicitly disabling the parallelism for the clean
      target, and it makes automated builds much more reliable.
      Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20180705131527.19749-1-linux@rasmusvillemoes.dk
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      da15fc2f
  4. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  5. 04 Feb, 2016 2 commits
  6. 29 Jan, 2016 2 commits
  7. 05 Nov, 2015 1 commit
  8. 22 Jun, 2015 1 commit
    • Jiri Olsa's avatar
      perf build: Fix single target build dependency check · 8e557351
      Jiri Olsa authored
      
      Currently if we build a single target like:
      
        $ touch util/map.c && make util/map.o
      
      It will not rebuild util/map.o if it already exists and util/map.c is
      modified.
      
      The reason is that the top-level 'Makefile' processes util/map.o as an
      implicit rule and if util/map.o exists make considers the 'util/map.o'
      target as done and will not nest into Makefile.perf.
      
      Adding FORCE for '%', because that's what we want to nest into
      Makefile.perf for any target.
      
      Adding Makefile into phony targets, because make tries to rebuild it and
      it's also resolved as '%' target.
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Lukas Wunner <lukas@wunner.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/1434977452-32520-4-git-send-email-jolsa@kernel.org
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      8e557351
  9. 12 May, 2015 1 commit
  10. 04 May, 2015 1 commit
  11. 26 Mar, 2015 1 commit
  12. 02 Mar, 2015 1 commit
  13. 16 Jan, 2014 1 commit
  14. 27 Nov, 2013 1 commit
  15. 14 Oct, 2013 2 commits
  16. 11 Oct, 2013 1 commit
    • Ingo Molnar's avatar
      tools: Harmonize the various build messages in perf, lib-traceevent, lib-lk · 65fb0992
      Ingo Molnar authored
      
      The various build lines from libtraceevent and perf mix up during a
      parallel build and produce unaligned output like:
      
          CC builtin-buildid-list.o
          CC builtin-buildid-cache.o
          CC builtin-list.o
        CC FPIC            trace-seq.o
          CC builtin-record.o
        CC FPIC            parse-filter.o
          CC builtin-report.o
          CC builtin-stat.o
        CC FPIC            parse-utils.o
        CC FPIC            kbuffer-parse.o
          CC builtin-timechart.o
          CC builtin-top.o
          CC builtin-script.o
        BUILD STATIC LIB   libtraceevent.a
          CC builtin-probe.o
          CC builtin-kmem.o
          CC builtin-lock.o
      
      To solve this, harmonize all the build message alignments to be similar
      to the kernel's kbuild output: prefixed by two spaces and 11-char wide.
      
      After the patch the output looks pretty tidy, even if output lines get
      mixed up:
      
        CC      builtin-annotate.o
        FLAGS:  * new build flags or cross compiler
        CC      builtin-bench.o
        AR      liblk.a
        CC      bench/sched-messaging.o
        CC FPIC event-parse.o
        CC      bench/sched-pipe.o
        CC FPIC trace-seq.o
        CC      bench/mem-memcpy.o
        CC      bench/mem-memset.o
        CC FPIC parse-filter.o
        CC      builtin-diff.o
        CC      builtin-evlist.o
        CC      builtin-help.o
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1381312169-17354-3-git-send-email-mingo@kernel.org
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      65fb0992
  17. 09 Oct, 2013 8 commits
    • Ingo Molnar's avatar
      tools/perf/build: Fix non-canonical directory names in O= · b102420b
      Ingo Molnar authored
      This was a long-standing bug, relative pathnames like O=dir did not fully
      work in the build system:
      
          $ make O=localdir clean
      
          SUBDIR Documentation
          ../../scripts/Makefile.include:3: *** O=localdir does not exist.  Stop.
          make[1]: *** [clean] Error 2
          make: *** [clean] Error 2
      
      Fix this by canonizing the directory before passing it to Makefile.perf.
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-hchMp1hozn9tqgswWcooxcru@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      b102420b
    • Ingo Molnar's avatar
      tools/perf/build: Exclude MAKEFLAGS from nested invocation · 684f434c
      Ingo Molnar authored
      In case the user specifies MAKEFLAGS as an environment variable,
      or uses 'make -jN' explicitly, the options can conflict and result in:
      
          BUILD: Doing 'make -j8' parallel build
          make[1]: warning: -jN forced in submake: disabling jobserver mode.
          GEN common-cmds.h
          make[1]: *** write jobserver: Bad file descriptor.  Stop.
      
      Make sure we invoke the main makefile in a pristine state.
      
      Users who want to do something non-standard can use the:
      
        make -f Makefile.perf
      
      method to invoke the makefile.
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-uen6hzTvkqqngqwjma9yoEgw@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      684f434c
    • Ingo Molnar's avatar
      tools/perf/build: Pass through all targets to Makefile.perf · b016a0dd
      Ingo Molnar authored
      
      Jiri reported that 'make .o' stopped working:
      
        > [jolsa@krava perf]$ make -f Makefile perf.o
        > cc    -c -o perf.o perf.c
        > In file included from builtin.h:4:0,
        >                  from perf.c:9:
        > util/util.h:74:24: fatal error: lk/debugfs.h: No such file or directory
        > compilation terminated.
        > make: *** [perf.o] Error 1
      
      This is due to GNU make having built-in rules for popular targets such
      as *.o. Clear them out so that all targets as passed through to Makefile.perf.
      Reported-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Link: http://lkml.kernel.org/n/tip-5wkuvmlaaxtfgepKcvRij8sh@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      b016a0dd
    • Ingo Molnar's avatar
      tools/perf/build: Standardize the various messages output by parallel make · 73a725f0
      Ingo Molnar authored
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-mky0rtpwxi3ivxsvdjoOEmhr@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      73a725f0
    • Ingo Molnar's avatar
      tools/perf/build: Flip Makefile.parallel and Makefile.perf · bd69cc28
      Ingo Molnar authored
      To make it more apparent that there is not change in functionality we introduced
      Makefile.parallel separately and now flip it with the main Makefile, which
      moves into Makefile.perf.
      
      The renames are:
      
         Makefile.parallel => Makefile
         Makefile          => Makefile.perf
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-igRfuw9ugbnnpixLd6wpptzl@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      bd69cc28
    • Ingo Molnar's avatar
      tools/perf/build: Invoke feature-checks 'clean' target from the main Makefile · de0f03fb
      Ingo Molnar authored
      config/Makefile is not included for the 'clean' target, so invoke the
      config/feature-checks/Makefile 'clean' target from Makefile.perf.
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-sh2cGvmsjbrazarlqre7pVwt@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      de0f03fb
    • Ingo Molnar's avatar
      tools/perf/build: Speed up the final link · c9404c66
      Ingo Molnar authored
      libtraceevent.a and liblk.a rules have always-missed dependencies,
      which causes python.so to be relinked at every build attempt - even
      if none of the affected code changes.
      
      This slows down re-builds unnecessarily, by adding more than a second
      to the build time:
      
        comet:~/tip/tools/perf> time make
      
        ...
      
          SUBDIR /fast/mingo/tip/tools/lib/lk/
          make[1]: `liblk.a' is up to date.
          SUBDIR /fast/mingo/tip/tools/lib/traceevent/
          LINK perf
          GEN python/perf.so
      
        real    0m1.701s
        user    0m1.338s
        sys     0m0.301s
      
      Add the (trivial) dependencies to not force a re-link.
      
      This speeds up an empty re-build enormously:
      
        comet:~/tip/tools/perf> time make
      
        ...
      
        real    0m0.207s
        user    0m0.134s
        sys     0m0.028s
      
      [ This adds some coupling between the build dependencies of
        libtraceevent and liblk - but until those stay relatively
        simple this should not be an issue. ]
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-wvmlrurufuk6mo1ovtNigguT@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      c9404c66
    • Ingo Molnar's avatar
      tools/perf/build: Speed up git-version test on re-make · c72e3f04
      Ingo Molnar authored
      util/PERF-VERSION-GEN is currently executed on every build attempt,
      and this script can take a lot of time on trees that are at a
      significant git-distance from Linus's tree:
      
        $ time util/PERF-VERSION-GEN
      
        real    0m4.343s
        user    0m4.176s
        sys     0m0.140s
      
      It also takes a lot of time if the Git repository is network attached, etc.,
      because the commands it uses:
      
              TAG=$(git describe --abbrev=0 --match "v[0-9].[0-9]*" 2>/dev/null )
      
      has to count commits from the nearest tag and thus has to access (and
      decompress) every git commit blob on the relevant version path.
      
      Even on Linus's tree it takes 0.28 seconds on a fast box to count all the
      commits and get the git version string:
      
        $ time util/PERF-VERSION-GEN
      
        real    0m0.279s
        user    0m0.247s
        sys     0m0.025s
      
      But the version string only has to be regenerated if the git repository's
      head commit changes. So add a dependency of ../../.git/HEAD and touch
      the file every time it's regenerated, so that Make's build rules can
      pick it up and cache the result:
      
        make: `PERF-VERSION-FILE' is up to date.
      
        real    0m0.184s
        user    0m0.117s
        sys     0m0.026s
      
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Link: http://lkml.kernel.org/n/tip-wvmlrurufuk6mo1ovtNigguT@git.kernel.org
      
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      c72e3f04
  18. 04 Oct, 2013 1 commit
  19. 05 Sep, 2013 1 commit
  20. 02 Sep, 2013 1 commit
  21. 29 Aug, 2013 2 commits
  22. 26 Aug, 2013 1 commit
  23. 07 Aug, 2013 1 commit
  24. 23 Jul, 2013 1 commit
  25. 22 Jul, 2013 1 commit
    • Kirill A. Shutemov's avatar
      perf tools: Fix build with perl 5.18 · 575bf1d0
      Kirill A. Shutemov authored
      
      perl.h from new Perl release doesn't like -Wundef and -Wswitch-default:
      
      /usr/lib/perl5/core_perl/CORE/perl.h:548:5: error: "SILENT_NO_TAINT_SUPPORT" is not defined [-Werror=undef]
       #if SILENT_NO_TAINT_SUPPORT && !defined(NO_TAINT_SUPPORT)
           ^
      /usr/lib/perl5/core_perl/CORE/perl.h:556:5: error: "NO_TAINT_SUPPORT" is not defined [-Werror=undef]
       #if NO_TAINT_SUPPORT
           ^
      In file included from /usr/lib/perl5/core_perl/CORE/perl.h:3471:0,
                       from util/scripting-engines/trace-event-perl.c:30:
      /usr/lib/perl5/core_perl/CORE/sv.h:1455:5: error: "NO_TAINT_SUPPORT" is not defined [-Werror=undef]
       #if NO_TAINT_SUPPORT
           ^
      In file included from /usr/lib/perl5/core_perl/CORE/perl.h:3472:0,
                       from util/scripting-engines/trace-event-perl.c:30:
      /usr/lib/perl5/core_perl/CORE/regexp.h:436:5: error: "NO_TAINT_SUPPORT" is not defined [-Werror=undef]
       #if NO_TAINT_SUPPORT
           ^
      In file included from /usr/lib/perl5/core_perl/CORE/hv.h:592:0,
                       from /usr/lib/perl5/core_perl/CORE/perl.h:3480,
                       from util/scripting-engines/trace-event-perl.c:30:
      /usr/lib/perl5/core_perl/CORE/hv_func.h: In function ‘S_perl_hash_siphash_2_4’:
      /usr/lib/perl5/core_perl/CORE/hv_func.h:222:3: error: switch missing default case [-Werror=switch-default]
         switch( left )
         ^
      /usr/lib/perl5/core_perl/CORE/hv_func.h: In function ‘S_perl_hash_superfast’:
      /usr/lib/perl5/core_perl/CORE/hv_func.h:274:5: error: switch missing default case [-Werror=switch-default]
           switch (rem) { \
           ^
      /usr/lib/perl5/core_perl/CORE/hv_func.h: In function ‘S_perl_hash_murmur3’:
      /usr/lib/perl5/core_perl/CORE/hv_func.h:398:5: error: switch missing default case [-Werror=switch-default]
           switch(bytes_in_carry) { /* how many bytes in carry */
           ^
      
      Let's disable the warnings for code which uses perl.h.
      Signed-off-by: default avatarKirill A. Shutemov <kirill@shutemov.name>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1372063394-20126-1-git-send-email-kirill@shutemov.name
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      575bf1d0
  26. 17 Jul, 2013 1 commit
    • Robert Richter's avatar
      perf tools: Fix 'make tools/perf' · ab4ecda5
      Robert Richter authored
      Boris just raised another variant of building perf tools which is
      broken:
      
       $ make tools/perf
       ...
           LINK /home/robert/cx/linux/tools/perf/perf
       gcc: error: ../linux/tools/lib/lk/liblk.a: No such file or directory
      
      The variant wasn't considered by:
      
       107de372
      
       perf tools: Fix build errors with O and DESTDIR make vars set
      
      There are other variant of building perf too:
      
       $ make -C tools perf
       $ make -C tools/perf
      
      Plus variants with O= and DESTDIR set.
      
      This patch fixes the above and was tested with the following:
      
       $ make O=... DESTDIR=... tools/perf
       $ make O=... DESTDIR=... -C tools/ perf
       $ make O=... DESTDIR=... -C tools/perf
       $ make tools/perf
       $ make -C tools/ perf
       $ make -C tools/perf
      Reported-by: default avatarBorislav Petkov <bp@alien8.de>
      Signed-off-by: default avatarRobert Richter <robert.richter@linaro.org>
      Signed-off-by: default avatarRobert Richter <rric@kernel.org>
      Cc: Borislav Petkov <bp@alien8.de>
      Cc: H. Peter Anvin <hpa@zytor.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: linux-tip-commits@vger.kernel.org
      Link: http://lkml.kernel.org/r/20130716145036.GH8731@rric.localhost
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ab4ecda5
  27. 12 Jul, 2013 1 commit
  28. 08 Jul, 2013 1 commit
  29. 30 May, 2013 1 commit