- 14 Oct, 2020 2 commits
-
-
Zhen Lei authored
Explicitly add "#address-cells = <0>" and "#size-cells = <0>" to eliminate below warnings. (spi_bus_bridge): /example-0/spi: incorrect #address-cells for SPI bus (spi_bus_bridge): /example-0/spi: incorrect #size-cells for SPI bus (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' Signed-off-by:
Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20201013160845.1772-5-thunder.leizhen@huawei.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Zhen Lei authored
scripts/dtc/checks.c: if (get_property(node, "spi-slave")) spi_addr_cells = 0; if (node_addr_cells(node) != spi_addr_cells) FAIL(c, dti, node, "incorrect #address-cells for SPI bus"); if (node_size_cells(node) != 0) FAIL(c, dti, node, "incorrect #size-cells for SPI bus"); The above code in check_spi_bus_bridge() require that the number of address cells must be 0. So we should explicitly declare "#address-cells = <0>". Signed-off-by:
Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20201013160845.1772-4-thunder.leizhen@huawei.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 13 Oct, 2020 2 commits
-
-
Rob Herring authored
booting-without-of.rst is an ancient document that first outlined Flattened DeviceTree on PowerPC initially. The DT world has evolved a lot in the 15 years since and booting-without-of.rst is pretty stale. The name of the document itself is confusing if you don't understand the evolution from real 'OpenFirmware'. Most of what booting-without-of.rst contains is now in the DT specification (which evolved out of the ePAPR). The few things that weren't documented in the DT specification are now. All that remains is the boot entry details, so let's move these to arch specific documents. The exception is arm which already has the same details documented. Cc: Frank Rowand <frowand.list@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Paul Mackerras <paulus@samba.org> Cc: Yoshinori Sato <...
-
Biju Das authored
Some hardware designs have USB typec connector attached to both SoC and super speed mux. We need to use separate connector node for such design. Signed-off-by:
Biju Das <biju.das.jz@bp.renesas.com> Link: https://lore.kernel.org/r/20200920134905.4370-2-biju.das.jz@bp.renesas.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 12 Oct, 2020 4 commits
-
-
Zhen Lei authored
Add properties: #address-cells, #size-cells and ranges. Due to the Hisilicon CPU controller node may contains child nodes, change the value of "additionalProperties" from "false" to "type: object". The corresponding examples are also added. Signed-off-by:
Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20201012061225.1597-11-thunder.leizhen@huawei.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Zhen Lei authored
Add properties: #reset-cells, #address-cells, #size-cells and ranges. Due to the Hisilicon system controller node may contains child nodes, change the value of "additionalProperties" from "false" to "type: object". The examples have also been updated. Signed-off-by:
Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20201012061225.1597-10-thunder.leizhen@huawei.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Krzysztof Kozlowski authored
Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check warnings like: arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0: 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm'] Acked-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200925212609.23093-1-krzk@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
Add a yamllint config file and support for running yamllint on DT binding schema files. This runs on the whole tree as yamllint is Python and suffers from Python's slow startup times. Users can run on individual files doing: yamllint -c Documentation/devicetree/bindings/.yamllint <binding file> Link: https://lore.kernel.org/r/20201009170557.168785-1-robh@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 10 Oct, 2020 1 commit
-
-
Mark-PK Tsai authored
Add binding for MStar interrupt controller. Signed-off-by:
Mark-PK Tsai <mark-pk.tsai@mediatek.com> Signed-off-by:
Marc Zyngier <maz@kernel.org> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20200902063344.1852-3-mark-pk.tsai@mediatek.com
-
- 08 Oct, 2020 7 commits
-
-
Serge Semin authored
These controllers are based on the DW APB SSI IP-core and embedded into the SoC, so two of them are equipped with IRQ, DMA, 64 words FIFOs and 4 native CS, while another one as being utilized by the Baikal-T1 System Boot Controller has got a very limited resources: no IRQ, no DMA, only a single native chip-select and just 8 bytes Tx/Rx FIFOs available. That's why we have to mark the IRQ to be optional for the later interface. The SPI controller embedded into the Baikal-T1 System Boot Controller can be also used to directly access an external SPI flash by means of a dedicated FSM. The corresponding MMIO region availability is switchable by the embedded multiplexor, which phandle can be specified in the dts node. * We added a new example to test out the non-standard Baikal-T1 System Boot SPI Controller DT binding. Co-developed-by:
Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru> Signed-off-by:
Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru> Signed-off-by:
Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201007235511.4935-21-Sergey.Semin@baikalelectronics.ru Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Dan Murphy authored
Add the binding for the TAS2764 Smart Amplifier. Signed-off-by:
Dan Murphy <dmurphy@ti.com> Link: https://lore.kernel.org/r/20201007155341.10139-1-dmurphy@ti.com Signed-off-by:
Mark Brown <broonie@kernel.org>
-
V Sujith Kumar Reddy authored
Adds bindings for lpass hdmi interface which can support audio path over dp. Signed-off-by:
V Sujith Kumar Reddy <vsujithk@codeaurora.org> Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Srinivasa Rao <srivasam@codeaurora.org> Tested-by:
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by:
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/1602134223-2562-3-git-send-email-srivasam@codeaurora.org Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Rob Herring authored
Document the PowerPC specific 'sleep' property as a schema. It is currently only documented in booting-without-of.rst which is getting removed. Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Signed-off-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201008142420.2083861-1-robh@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Naoki Hayama authored
Fix comment typo. s/abitrary/arbitrary/ Signed-off-by:
Naoki Hayama <naoki.hayama@lineo.co.jp> Link: https://lore.kernel.org/r/614fe604-ab8e-21cb-0c3a-db6ddeff2a4e@lineo.co.jp Signed-off-by:
Rob Herring <robh@kernel.org>
-
Naoki Hayama authored
Fix comment typo. s/abitrary/arbitrary/ Signed-off-by:
Naoki Hayama <naoki.hayama@lineo.co.jp> Link: https://lore.kernel.org/r/7d1856e2-84c7-ab19-863d-2d500569d58c@lineo.co.jp Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rajendra Nayak authored
Venus needs to vote for the performance state of a power domain (cx) to be able to support DVFS. This 'cx' power domain is controlled by rpmh and is a common power domain (scalable) not specific to venus alone. This is optional in the sense that, leaving this power domain out does not really impact the functionality but just makes the platform a little less power efficient. Signed-off-by:
Rajendra Nayak <rnayak@codeaurora.org> Reviewed-by:
Rob Herring <robh@kernel.org> Reviewed-by:
Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by:
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-
- 07 Oct, 2020 10 commits
-
-
Marc Kleine-Budde authored
Since commit: 048e3a34 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode acknowledge and not the acknowledgment on chip level. This means the 4th and 5th value of the property "fsl,stop-mode" isn't used anymore. It will be removed from the driver in the next patch, so remove it from the binding documentation. Link: http://lore.kernel.org/r/20201006203748.1750156-14-mkl@pengutronix.de Fixes: 048e3a34 ("can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment") Cc: devicetree <devicetree@vger.kernel.org> Cc: Joakim Zhang <qiangqing.zhang@nxp.com> Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
-
Michael Walle authored
The compatible is a pattern match. Explicitly list all possible values. Also mention that the ls1028ar1 must be followed by lx2160ar1. Signed-off-by:
Michael Walle <michael@walle.cc> Link: https://lore.kernel.org/r/20201001091131.30514-2-michael@walle.cc Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
-
Lad Prabhakar authored
Document SoC specific bindings for RZ/G2H (R8A774E1) SoC. Signed-off-by:
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by:
Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201005081319.29322-3-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
-
Lad Prabhakar authored
Document the support for rcar_canfd on R8A774E1 SoC devices. Signed-off-by:
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by:
Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201005081319.29322-2-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
-
Lad Prabhakar authored
Document RZ/G1H (r8a7742) SoC specific bindings. The R8A7742 CAN module is identical to R-Car Gen2 family. No driver change is needed due to the fallback compatible value "renesas,rcar-gen2-can". Signed-off-by:
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by:
Chris Paterson <Chris.Paterson2@renesas.com> Link: https://lore.kernel.org/r/20200816190732.6905-3-prabhakar.mahadev-lad.rj@bp.renesas.com Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Marc Kleine-Budde <mkl@pengutronix.de>
-
Rob Herring authored
In order to add meta-schema checks for additional/unevaluatedProperties being present, all schema need to make this explicit. As common/shared schema are included by other schemas, they should always allow for additionalProperties. Acked-by:
Mark Brown <broonie@kernel.org> Acked-by:
Krzysztof Kozlowski <krzk@kernel.org> Acked-by:
Sebastian Reichel <sre@kernel.org> Acked-by:
Chanwoo Choi <cw00.choi@samsung.com> Acked-By:
Vinod Koul <vkoul@kernel.org> Acked-by:
Lee Jones <lee.jones@linaro.org> Acked-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Acked-by:
Ulf Hansson <ulf.hansson@linaro.org> Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by:
Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20201005183830.486085-5-robh@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
In cases where we don't reference another schema, 'additionalProperties' can be used instead. This is preferred for now as 'unevaluatedProperties' support isn't implemented yet. In a few cases, this means adding some missing property definitions of which most are for SPI bus properties. 'unevaluatedProperties' is not going to work for the SPI bus properties anyways as they are evaluated from the parent node, not the SPI child node. Acked-by:
Mark Brown <broonie@kernel.org> Acked-by:
Krzysztof Kozlowski <krzk@kernel.org> Acked-by:
Lee Jones <lee.jones@linaro.org> Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Acked-by:
Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20201005183830.486085-3-robh@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
This doesn't yet do anything in the tools, but make it explicit so we can check either 'unevaluatedProperties' or 'additionalProperties' is present in schemas. 'unevaluatedProperties' is appropriate when including another schema (via '$ref') and all possible properties and/or child nodes are not explicitly listed in the schema with the '$ref'. This is in preparation to add a meta-schema to check for missing 'unevaluatedProperties' or 'additionalProperties'. This has been a constant source of review issues. Acked-by:
Mark Brown <broonie@kernel.org> Acked-by:
Wolfram Sang <wsa@kernel.org> Acked-by:
Krzysztof Kozlowski <krzk@kernel.org> Acked-By:
Vinod Koul <vkoul@kernel.org> Acked-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Ulf Hansson <ulf.hansson@linaro.org> Acked-by:
Guenter Roeck <linux@roeck-us.net> Acked-by:
Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Link: https://lore.kernel.org/r/20201005183830.486085-2-robh@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Marlon Rac Cambasis authored
Revised patch fixing six spelling errors within Documentation/devicetree/bindings/. "specfied" replaced with "specified" in all three files modified. "atleast" seperated into "at least" three times in samsung-pinctrl.txt. This should remove any confusion that a reader might have. Signed-off-by:
Marlon Rac Cambasis <marlonrc08@gmail.com> Link: https://lore.kernel.org/r/20201007071705.GA11381@marlonpc-debian Signed-off-by:
Rob Herring <robh@kernel.org>
-
Clément Péron authored
Recently introduced Allwinner A100 pinctrl block has 7 interrupts. This trig a warning when running dtb_checks: sun50i-a100-allwinner-perf1.dt.yaml: pinctrl@300b000: interrupts: [...] is too long From schema: .../allwinner,sun4i-a10-pinctrl.yaml Fix this by allowing up to 7 interrupts. Signed-off-by:
Clément Péron <peron.clem@gmail.com> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201005190939.21016-1-peron.clem@gmail.com Signed-off-by:
Linus Walleij <linus.walleij@linaro.org>
-
- 06 Oct, 2020 14 commits
-
-
Chu Lin authored
max20730 Integrated, Step-Down Switching Regulator with PMBus Signed-off-by:
Chu Lin <linchuyuan@google.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201004031445.2321090-2-linchuyuan@google.com Signed-off-by:
Guenter Roeck <linux@roeck-us.net>
-
Rahul Tanwar authored
PVT controller (MR75203) is used to configure & control Moortec embedded analog IP which contains temprature sensor(TS), voltage monitor(VM) & process detector(PD) modules. Add DT bindings schema for PVT controller. Signed-off-by:
Rahul Tanwar <rahul.tanwar@linux.intel.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/b540b49ca47d75c5f716f8a4e4eed0664a1116bf.1601889876.git.rahul.tanwar@linux.intel.com Signed-off-by:
Guenter Roeck <linux@roeck-us.net>
-
Alban Bedel authored
Some boards might have a regulator that control the +VS supply, add it to the bindings. Signed-off-by:
Alban Bedel <alban.bedel@aerq.com> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201001145738.17326-3-alban.bedel@aerq.com Signed-off-by:
Guenter Roeck <linux@roeck-us.net>
-
Alban Bedel authored
In order to automate the verification of DT nodes convert lm75.txt to lm75.yaml. Signed-off-by:
Alban Bedel <alban.bedel@aerq.com> Reviewed-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201001145738.17326-2-alban.bedel@aerq.com Signed-off-by:
Guenter Roeck <linux@roeck-us.net>
-
Zhen Lei authored
Convert the Hisilicon Hi6220 domain controllers binding to DT schema format using json-schema. All of them are grouped into one yaml file, to help users understand differences and avoid repeated descriptions. Signed-off-by:
Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20200930031712.2365-16-thunder.leizhen@huawei.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sagar Kadam authored
Convert device tree bindings for SiFive's PWM controller to YAML format. Signed-off-by:
Sagar Kadam <sagar.kadam@sifive.com> Link: https://lore.kernel.org/r/1601393531-2402-4-git-send-email-sagar.kadam@sifive.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sagar Kadam authored
Convert device tree bindings for SiFive's PLIC to YAML format Signed-off-by:
Sagar Kadam <sagar.kadam@sifive.com> Link: https://lore.kernel.org/r/1601393531-2402-3-git-send-email-sagar.kadam@sifive.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sagar Kadam authored
FU540-C000 SoC from SiFive has a PRCI block, here we convert the device tree bindings from txt to YAML. Signed-off-by:
Sagar Kadam <sagar.kadam@sifive.com> Link: https://lore.kernel.org/r/1601393531-2402-2-git-send-email-sagar.kadam@sifive.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Krzysztof Kozlowski authored
There are two vendor prefixes for Gateworks: "gw" and "gateworks". Favor the longer one (more descriptive) and mark "gw" as deprecated so it will not be used in new bindings. Reviewed-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20201003103335.23404-1-krzk@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
Another round of wack-a-mole. The json-schema default is additional unknown properties are allowed, but for DT all properties should be defined. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Baolin Wang <baolin.wang7@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by:
Guenter Roeck <linux@roeck-us.net> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-By:
Vinod Koul <vkoul@kernel.org> Acked-by:
Lee Jones <lee.jones@linaro.org> Acked-by:
Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: ...
-
Suman Anna authored
Update the AM65x HwSpinlock example to fix couple of warnings that started showing up after the conversion of K3 bindings to YAML format in commit 66e06509 ("dt-bindings: arm: ti: Convert K3 board/soc bindings to DT schema"). compatible: ['ti,am654'] is not valid under any of the given schemas (Possible causes of the failure): compatible: ['ti,am654'] is too short compatible:0: 'ti,am654' is not one of ['ti,am654-evm'] Also, fix one of the node names while at this. Reviewed-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Suman Anna <s-anna@ti.com> Link: https://lore.kernel.org/r/20200928225155.12432-1-s-anna@ti.com Signed-off-by:
Rob Herring <robh@kernel.org>
-
Ikjoon Jang authored
Add MT8192 spi-nor controller support. Signed-off-by:
Ikjoon Jang <ikjn@chromium.org> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20201006155010.v5.1.I4cd089ef1fe576535c6b6e4f1778eaab1c4441cf@changeid Signed-off-by:
Mark Brown <broonie@kernel.org>
-
Krzysztof Kozlowski authored
The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like: serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200925212649.23183-1-krzk@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-
Krzysztof Kozlowski authored
Add quite common property - power-domains - to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: mailbox@5d280000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' Reviewed-by:
Dong Aisheng <aisheng.dong@nxp.com> Signed-off-by:
Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20201002161837.5784-1-krzk@kernel.org Signed-off-by:
Rob Herring <robh@kernel.org>
-