Skip to content

GitLab

Switch branch/tag
  1. 24 Oct, 2016 2 commits
  3. 21 Sep, 2016 6 commits
  5. 14 Aug, 2016 2 commits
  7. 20 Jul, 2016 1 commit
  9. 25 Jan, 2016 1 commit
  11. 12 Jan, 2016 1 commit
  13. 10 Jul, 2015 1 commit
  15. 07 May, 2015 1 commit
  17. 17 Apr, 2015 1 commit
  19. 27 Feb, 2015 2 commits
  21. 28 Jan, 2015 1 commit
  23. 02 Dec, 2014 1 commit
    • Dan Carpenter's avatar
      CodingStyle: add some more error handling guidelines · ea040360
      Dan Carpenter authored 
      
I added a paragraph on choosing label names, and updated the example
code to use a better label name.  I also cleaned up the example code to
more modern style by moving the allocation out of the initializer and
changing the NULL check.

Perhaps the most common type of error handling bug in the kernel is "one
err bugs".  CodingStyle already says that we should "avoid nesting" by
using error labels and one err style error handling tends to have
multiple indent levels, so this was already bad style.  But I've added a
new paragraph explaining how to avoid one err bugs by using multiple
error labels which is, hopefully, more clear.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
[jc: added GFP_KERNEL to kmalloc() call]
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
      ea040360
  25. 03 Nov, 2014 1 commit
  27. 26 Aug, 2014 1 commit
  29. 04 Jun, 2014 1 commit
    • Dan Streetman's avatar
      Documentation: expand/clarify debug documentation · 6e099f55
      Dan Streetman authored 
      
The pr_debug() and related debug print macros all differ from the normal
pr_XXX() macros, in that the normal ones print unconditionally, while
the debug macros are compiled out unless DEBUG is defined or
CONFIG_DYNAMIC_DEBUG is set.  This isn't obvious, and the only way to
find this out is either to review the actual printk.h code or to read
CodingStyle, and the message there doesn't highlight the fact.

Change Documentation/CodingStyle to clearly indicate that pr_debug() and
related debug printing macros behave differently than all other pr_XXX()
macros, and attempt to clarify when and where the different debug
printing methods might be used.

Add short comment to printk.h above the pr_XXX() macros indicating that
while these macros print unconditionally, pr_debug() does not.
Signed-off-by: default avatarDan Streetman <ddstreet@ieee.org>
Cc: Joe Perches <joe@perches.com>
Cc: Fabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      6e099f55
  31. 03 Jul, 2013 1 commit
  33. 11 Jan, 2013 1 commit
    • Kees Cook's avatar
      Documentation: remove depends on CONFIG_EXPERIMENTAL · 0335cb46
      Kees Cook authored 
      
The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
while now and is almost always enabled by default. As agreed during the
Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

CC: Rob Landley <rob@landley.net>
CC: Jiri Kosina <jkosina@suse.cz>
CC: Masanari Iida <standby24x7@gmail.com>
CC: Jason Wessel <jason.wessel@windriver.com>
CC: Richard L Maliszewski <richard.l.maliszewski@intel.com>
CC: Gang Wei <gang.wei@intel.com>
CC: Shane Wang <shane.wang@intel.com>
CC: Harry Wei <harryxiyou@gmail.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarJason Wessel <jason.wessel@windriver.com>
      0335cb46
  35. 05 Oct, 2012 1 commit
  37. 01 Jun, 2012 1 commit
  39. 30 Mar, 2012 1 commit
  41. 04 Nov, 2011 1 commit
  43. 06 Aug, 2011 1 commit
  45. 06 Jul, 2011 1 commit
  47. 23 Mar, 2011 1 commit
  49. 16 Mar, 2011 1 commit
  51. 12 Jun, 2009 1 commit
  53. 30 Jan, 2009 2 commits
  55. 25 Jul, 2008 1 commit
  57. 17 Oct, 2007 1 commit
  59. 18 Jul, 2007 1 commit
  61. 16 Jul, 2007 1 commit