Skip to content

GitLab

Switch branch/tag
History Find file
Clone
ima: Fix return value of ima_write_policy()
Roberto Sassu authored 
[ Upstream commit 2e3a34e9 ]

This patch fixes the return value of ima_write_policy() when a new policy
is directly passed to IMA and the current policy requires appraisal of the
file containing the policy. Currently, if appraisal is not in ENFORCE mode,
ima_write_policy() returns 0 and leads user space applications to an
endless loop. Fix this issue by denying the operation regardless of the
appraisal mode.

Cc: stable@vger.kernel.org # 4.10.x
Fixes: 19f8a847

 ("ima: measure and appraise the IMA policy itself")
Signed-off-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: default avatarKrzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
fa63cb9b
Name Last commit Last update
..
apparmor apparmor: don't try to replace stale label in ptrace access check
integrity ima: Fix return value of ima_write_policy()
keys KEYS: Avoid false positive ENOMEM error on key read
loadpin security: mark LSM hooks as __ro_after_init
selinux selinux: properly handle multiple messages in selinux_netlink_send()
smack smack: use GFP_NOFS while holding inode_smack::smk_lock
tomoyo License cleanup: add SPDX GPL-2.0 license identifier to files with no license
yama Yama: Check for pid death before checking ancestry
Kconfig /dev/mem: Add bounce buffer for copy-out
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license
commoncap.c cap_inode_getsecurity: use d_find_any_alias() instead of d_find_alias()
device_cgroup.c device_cgroup: fix RCU imbalance in error case
inode.c securityfs: fix use-after-free on symlink traversal
lsm_audit.c missing barriers in some of unix_sock ->addr and ->path accesses
min_addr.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license
security.c LSM: Check for NULL cred-security on free