Skip to content

GitLab

Switch branch/tag
History Find file
Clone
ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk
Takashi Sakamoto authored 
commit 65845f29 upstream.

In IEC 61883-6, one data block transfers one event. In ALSA, the event equals one PCM frame,
hence one data block transfers one PCM frame. But Dice has a quirk at higher sampling rate
(176.4/192.0 kHz) that one data block transfers two PCM frames.

Commit 10550bea

 ("ALSA: dice/firewire-lib: Keep dualwire mode but obsolete
CIP_HI_DUALWIRE") moved some codes related to this quirk into Dice driver. But the commit
forgot to add arrangements for PCM period interrupts and DMA pointer updates. As a result, Dice
driver cannot work correctly at higher sampling rate.

This commit adds 'double_pcm_frames' parameter to amdtp structure for this quirk. When this
parameter is set, PCM period interrupts and DMA pointer updates occur at double speed than in
IEC 61883-6.
Reported-by: default avatarDaniel Robbins <drobbins@funtoo.org>
Fixes: 10550bea ("ALSA: dice/firewire-lib: Keep dua...
329ea7a2
Name Last commit Last update
..
bebob ALSA: bebob: Correction for return value of special_clk_ctl_put() in error
fireworks ALSA: fireworks: Remove meaningless mutex_destroy()
Kconfig ALSA: firewire: Fix dependency on PCM and rawmidi
Makefile ALSA: bebob: Add skelton for BeBoB based devices
amdtp.c ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk
amdtp.h ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk
cmp.c ALSA: firewire-lib: Fix sparse warning of incorrect type in assignment
cmp.h ALSA: firewire-lib: Add a new function to check others' connection
dice-interface.h ALSA: dice: document quadlet alignment
dice.c ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk
fcp.c ALSA: firewire-lib: Remove a comment about restriction of asynchronous operation
fcp.h ALSA: firewire-lib: Add some AV/C general commands
isight.c ALSA: firewire: Convert to snd_card_new() with a device pointer
iso-resources.c sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed
iso-resources.h firewire: octlet AT payloads can be stack-allocated
lib.c ALSA: firewire: extend snd_fw_transaction()
lib.h ALSA: firewire: extend snd_fw_transaction()
packets-buffer.c sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed
packets-buffer.h ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver
scs1x.c ALSA: firewire: Convert to snd_card_new() with a device pointer
speakers.c ALSA: firewire-lib: Add some AV/C general commands