fs: jfs: fix possible NULL pointer dereference in dbFree()
Zixuan Fu authored
[ Upstream commit 0d4837fd ]

In our fault-injection testing, the variable "nblocks" in dbFree() can be
zero when kmalloc_array() fails in dtSearch(). In this case, the variable
 "mp" in dbFree() would be NULL and then it is dereferenced in
"write_metapage(mp)".

The failure log is listed as follows:

[   13.824137] BUG: kernel NULL pointer dereference, address: 0000000000000020
...
[   13.827416] RIP: 0010:dbFree+0x5f7/0x910 [jfs]
[   13.834341] Call Trace:
[   13.834540]  <TASK>
[   13.834713]  txFreeMap+0x7b4/0xb10 [jfs]
[   13.835038]  txUpdateMap+0x311/0x650 [jfs]
[   13.835375]  jfs_lazycommit+0x5f2/0xc70 [jfs]
[   13.835726]  ? sched_dynamic_update+0x1b0/0x1b0
[   13.836092]  kthread+0x3c2/0x4a0
[   13.836355]  ? txLockFree+0x160/0x160 [jfs]
[   13.836763]  ? kthread_unuse_mm+0x160/0x160
[   13.837106]  ret_from_fork+0x1f/0x30
[   13.837402]  </TASK>
...

This patch adds a NULL check of "mp" before "write_met...
9dfa8d08
Name Last commit Last update
..
Kconfig docs: fix a couple of new broken references
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license
acl.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
file.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
inode.c jfs: prevent NULL deref in diFree
ioctl.c vfs: create a generic checking and prep function for FS_IOC_SETFLAGS
jfs_acl.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_btree.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_debug.c proc: convert everything to "struct proc_ops"
jfs_debug.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_dinode.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_discard.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_discard.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_dmap.c fs: jfs: fix possible NULL pointer dereference in dbFree()
jfs_dmap.h jfs: Fix array index bounds check in dbAdjTree
jfs_dtree.c jfs: Replace zero-length array with flexible-array member
jfs_dtree.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_extent.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_extent.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_filsys.h JFS: more checks for invalid superblock
jfs_imap.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_imap.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_incore.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_inode.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_inode.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
jfs_lock.h
jfs_logmgr.c
jfs_logmgr.h
jfs_metapage.c
jfs_metapage.h
jfs_mount.c
jfs_superblock.h
jfs_txnmgr.c
jfs_txnmgr.h
jfs_types.h
jfs_umount.c
jfs_unicode.c
jfs_unicode.h
jfs_uniupr.c
jfs_xattr.h
jfs_xtree.c
jfs_xtree.h
namei.c
resize.c
super.c
symlink.c
xattr.c